Revert "Move .swiftmodule output directory (#7103)" #7173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 20b86fe.
|
swiftlang/sourcekit-lsp#992 |
|
@swift-ci please test package compatibility |
|
The issue in macOS self-hosted doesn't look related to this PR... |
|
swiftlang/sourcekit-lsp#992 |
|
macOS test failure unrelated, caused by an older test regressing per a discussion at /~https://github.com/apple/swift-package-manager/pull/3562/files#r1422648829 |
|
We can close this in favor of #7180 |
neonichu
added a commit
that referenced
this pull request
Dec 12, 2023
When using XCBuild, we don't segment Swift modules into a "Modules" subdirectory, so we have to special case this during installation. This should fix the same issue as the revert in #7173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 20b86fe.