Async package collections tests #7156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an async fixture method Adds async default implementation for several protocols
AndrewHoos
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
tomerd
approved these changes
Dec 2, 2023
tomerd
reviewed
Dec 2, 2023
| print("stderr:", stderr) | ||
| throw error | ||
| } | ||
| } |
MaxDesiatov
approved these changes
Dec 2, 2023
Sources/PackageCollections/Storage/PackageCollectionsSourcesStorage.swift
Outdated
Show resolved
Hide resolved
Sources/PackageCollections/Storage/SQLitePackageCollectionsStorage.swift
Show resolved
Hide resolved
Sources/PackageCollections/Storage/SQLitePackageCollectionsStorage.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
force-pushed
the
async-PackageCollectionsTests
branch
from
1001c6a to
796f770
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt proper async/await for PackageCollectionsTests
Motivation:
Move more of the testing to be async/await native to make it easier to migrate to async/await in the core libraries
Modifications:
1 commit that adds an async fixture variant
1 commit that replaces a lot of temp_await
Result:
Less than 100 uses of temp_await in the repo