Remove discovery target in swift-testing case #7123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
MaxDesiatov
reviewed
Nov 27, 2023
MaxDesiatov
reviewed
Nov 27, 2023
MaxDesiatov
reviewed
Nov 27, 2023
|
@swift-ci please test |
|
@neonichu Mind taking the lead here? |
|
@swift-ci please test |
MaxDesiatov
changed the title
|
@swift-ci test windows |
MaxDesiatov
reviewed
Dec 4, 2023
MaxDesiatov
approved these changes
Dec 4, 2023
This PR removes the empty test discovery target created when running swift-testing-based tests. This target is necessary on Linux when running XCTest-based tests, but since swift-testing performs all its own discovery, it's just overhead there. Fixed by @neonichu, editorialized here by @grynspan (in case GitHub gets confused about it.)
grynspan
force-pushed
the
swift-testing-integration-no-discovery-target
branch
from
05a1aea to
a4eda63
Compare
|
Rebased and squashed. |
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please clean test Windows |
|
@swift-ci please test Windows |
1 similar comment
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the empty test discovery target created when running swift-testing-based tests. This target is necessary on
Linuxnon-Darwin targets when running XCTest-based tests, but since swift-testing performs all its own discovery, it's just overhead there.Fixed by @neonichu, editorialized here by @grynspan (in case GitHub gets confused about it.)