NFC: 5.9 Documentation update. #6434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 11, 2023 12:53
…wift-package-manager into zkiraly/5.9-documentation-update Catching up with the origin.
|
This is ready for engineering review. |
|
@swift-ci please smoke test. |
MaxDesiatov
reviewed
Apr 13, 2023
| @@ -47,7 +47,7 @@ public struct Resource { | |||
|
|
|||
| /// The rule for the resource. | |||
| let rule: String | |||
|
|
|||
There was a problem hiding this comment.
nit: trailing whitespace
neonichu
reviewed
Apr 14, 2023
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| /// The build configuration such as debug or release. | |||
| public struct BuildConfiguration { | |||
| /// The configuration of the build. Valid values are `debug` and `release`. | |||
| let config: String | |||
There was a problem hiding this comment.
This should not be public, right? Will it still show up in the developer docs?
tomerd
approved these changes
Apr 17, 2023
|
@swift-ci smoke test |
zkiraly
added a commit
to zkiraly/swift-package-manager
that referenced
this pull request
May 2, 2023
* Updated documentation for BuildSettings. * Updated documentation for PackageDescription.
neonichu
pushed a commit
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review and update the documentation for SwiftPM 5.9
Motivation:
A couple of new API were added to
PackageDescription, and these needed new documentation, and in some cases review.Modifications:
Documentation was added or updated. Nearly all the changes are for post 5.7 API.
Result:
There will be up-to-date documentation in
PackageDescriptionthat conforms to the current documentation style.