ManifestSourceGeneration incorrectly writes out DriverKit instead of driverKit
#6405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f `driverKit` The manifest source generation uses the wrong spelling for this enum. AFAIK there haven't been any reports of this affecting anyone yet — this was found during code inspection while making another change. The incorrect spelling is for both the platform version declaration and the spelling in the condition. This change also adds a unit test to check the latest versions of each of the platforms, and another one to check all the supported platform conditions. rdar://107795051
|
@swift-ci please smoke test |
neonichu
approved these changes
Apr 10, 2023
abertelrud
added a commit
to abertelrud/swift-package-manager
that referenced
this pull request
Apr 10, 2023
…f `driverKit` (swiftlang#6405) The manifest source generation uses the wrong spelling for this enum. AFAIK there haven't been any reports of this affecting anyone yet — this was found during code inspection while making another change. The incorrect spelling is for both the platform version declaration and the spelling in the condition. This change also adds a unit test to check the latest versions of each of the platforms, and another one to check all the supported platform conditions. rdar://107795051 (cherry picked from commit 5d83b59)
abertelrud
added a commit
that referenced
this pull request
Apr 10, 2023
…tead of `driverKit` (#6405) (#6406) The manifest source generation uses the wrong spelling for this enum. AFAIK there haven't been any reports of this affecting anyone yet — this was found during code inspection while making another change. The incorrect spelling is for both the platform version declaration and the spelling in the condition. This change also adds a unit test to check the latest versions of each of the platforms, and another one to check all the supported platform conditions. rdar://107795051 (cherry picked from commit 5d83b59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manifest source generation uses the wrong spelling for this enum. AFAIK there haven't been any reports of this affecting anyone yet — this was found during code inspection while making another change. The incorrect spelling is for both the platform version declaration and the spelling in the condition.
This change also adds a unit test to check the latest versions of each of the platforms, and another one to check all the supported platform conditions.
rdar://107795051