PackageModel, CoreCommands: fix build flags not passed #6380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When computing `SwiftTool/_buildParameters`, command-line options that customize `BuildFlags` values are not merged with `BuildFlags` from the computed toolchain/destination. Added `mutating func append(_: BuildFlags)` on the `BuildFlags` type for easier merging of multiple values into one, which is then used in `SwiftTool/_buildParameters`. rdar://106077959
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
|
@swift-ci smoke test |
neonichu
approved these changes
Apr 4, 2023
tomerd
approved these changes
Apr 4, 2023
aleksproger
pushed a commit
to aleksproger/swift-package-manager
that referenced
this pull request
May 18, 2023
**Content** - Added logic to resolve SDK paths whe building for Appli platforms - Added specific structure PlatformSDKPaths insted of simple tuple to represetn paths for platform headers/sdk - Destination.defaultDestination now instead of silent fallback to host emits error when triple is not supported - Added changes from swiftlang#6380 to pass --target fla to clang/swiftc with provided triple - Added validation of supported triples in applePlatformDestination() to ensure correct combination and enforce specifying the os version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When computing
SwiftTool/_buildParameters, command-line options that customizeBuildFlagsvalues are not merged withBuildFlagsfrom the computed toolchain/destination.rdar://106077959
Modifications:
Added
mutating func append(_: BuildFlags)on theBuildFlagstype for easier merging of multiple values into one, which is then used inSwiftTool/_buildParameters.