New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependency Scanning] Upon scan failure, ensure scanner diagnostics are emitted #1518

Merged

artemcm merged 1 commit into swiftlang:main from artemcm:BetterLibSwiftScanDiagReporting

Jan 4, 2024

Contributor

artemcm commented Jan 3, 2024

By catching the relevant errors as thrown from the InterModuleDependencyOracle and ensuring diagnostics are emitted before re-throwing them.


          [Dependency Scanning] Upon scan failure, ensure scanner diagnostics a…

eca2bf0

…re emitted

Contributor Author

artemcm commented Jan 3, 2024

artemcm requested a review from owenv

January 3, 2024 22:02

owenv approved these changes

View reviewed changes

artemcm merged commit a768642 into swiftlang:main

artemcm deleted the BetterLibSwiftScanDiagReporting branch

January 4, 2024 16:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet