Introduce -emit-api-descriptor-path option #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
xymus,
edymtt,
nkcsgexi,
artemcm and
cachemeifyoucan
cachemeifyoucan
approved these changes
Oct 6, 2023
| let jobs = try driver.planBuild().removingAutolinkExtractJobs() | ||
| let compileJob = try XCTUnwrap(jobs.first(where: {$0.kind == .compile})) | ||
|
|
||
| let supplementaryOutputs = try XCTUnwrap(compileJob.commandLine.supplementaryOutputFilemap) |
There was a problem hiding this comment.
does this always use file map file?
There was a problem hiding this comment.
Apparently so with enough input files. This is the logic that determines whether or not an output file map will be used:
if inputsGeneratingCodeCount * FileType.allCases.count > fileListThreshold {
There was a problem hiding this comment.
Right, my question is if you just pass the option to set threshold to 0?
There was a problem hiding this comment.
Ah, yeah I could do that.
tshortli
force-pushed
the
api-extract-supplementary-output
branch
from
7e7543b to
ca0a910
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
artemcm
approved these changes
Oct 9, 2023
This option and its argument, when specified on the driver command line, should be passed through to jobs that emit modules and have access to the whole module. Resolves rdar://116538520
tshortli
force-pushed
the
api-extract-supplementary-output
branch
from
ca0a910 to
bab5b4c
Compare
|
In the latest change I've also updated all the existing tests to use the new utility for extracting the supplementary file map from the command line. |
|
@swift-ci test |
|
@swift-ci test Windows |
1 similar comment
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option and its argument, when specified on the driver command line, should be passed through to jobs that emit modules and have access to the whole module.
Resolves rdar://116538520