Fix a non-deterministic test failure #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Aug 30, 2023
|
|
||
| let didChangeTextDocumentExpectation = self.expectation(description: "didChangeTextDocument") | ||
| )), { (note: LanguageServerProtocol.Notification<PublishDiagnosticsNotification>) -> Void in | ||
| log("Received diagnsotics for open - syntactic") |
There was a problem hiding this comment.
Nitpick:
Suggested change
| log("Received diagnsotics for open - syntactic") | |
| log("Received diagnostics for open - syntactic") |
Same a couple lines down too
We weren’t handling the notifications sent from the `DidOpenTextDocumentNotification`, which could cause test failures based on the notification timings relative to the notifications from the `DidChangeTextDocumentNotification`.
ahoppen
force-pushed
the
ahoppen/fix-non-deterministic-test-failure
branch
from
0b7cf3f to
6ad35c4
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
1 similar comment
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren’t handling the notifications sent from the
DidOpenTextDocumentNotification, which could cause test failures based on the notification timings relative to the notifications from theDidChangeTextDocumentNotification.