Register diagnostics in currentDiagnostics when performing a diagnostic pull request
#777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
benlangmuir
approved these changes
Jul 19, 2023
tristanlabelle
approved these changes
Jul 20, 2023
…stic pull request We were registering new diagnsotics in `currentDiagnostics` when the diagnostics got pushed to us by sourcekitd, but not when they were pulled using the diagnostic request. Fixes swiftlang#776 rdar://112539108
ahoppen
force-pushed
the
ahoppen/code-actions-for-pulled-diags
branch
from
9358e60 to
8804e95
Compare
|
Thanks for the review @tristanlabelle. Two good catches |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were registering new diagnsotics in
currentDiagnosticswhen the diagnostics got pushed to us by sourcekitd, but not when they were pulled using the diagnostic request.Fixes #776
rdar://112539108