Swiftinterface symbol lookup (release/5.9) #750
Merged
+248
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adam-fowler
commented
May 24, 2023
•
adam-fowler
commented
- Explanation: Jumping to a definition to a type that is defined in the SDK and not the user’s code currently doesn’t work because SourceKit-LSP doesn’t know where to jump to. This add support for jumping to a declaration in the SDK by using the existing infrastructure to generate a generated interface for the SDK module, using sourcekitd to figure out where in that interface the type is declared and jumping to it.
- Scope: Jump to definition of SDK symbols
- Risk: Low, previously jump to definition didn’t work for these symbols add all
- Testing: Added test case
- Issue: Add support for jump to definition for stdlib/Foundation symbols #618 / rdar://99329577
- Reviewer: @ahoppen on Swiftinterface symbol lookup #747
Generate swiftinterface for symbol lookup When a symbol definition returns it is in a swiftinterface file, create textual version of swiftinterface and return that in response. Extend OpenInterface to also seatch for a symbol Fix warning Syntax changes after review Move module name split into OpenInterfaceRequest Use group names when running open interface request Requested changes from PR rename symbol to symbolUSR Cleanup OpenInterfaceRequest.init Fix tests Added testDefinitionInSystemModuleInterface Use SwiftPMPackage test module Added version of buildAndIndex that includes system symbols Merge buildAndIndexWithSystemSymbols with buildAndIndex Added specific test project for system swiftinterface tests Add multiple tests for various system modules
adam-fowler
force-pushed
the
af-swiftinterface-symbol-lookup-5.9
branch
from
6306c40 to
9ca8966
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
May 26, 2023
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.