Rename unregisterTimeHistogram to unregisterDurationHistogram #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
approved these changes
Feb 13, 2024
fabianfett
approved these changes
Feb 13, 2024
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The new 2.0 alpha APIs have asymmetric names for registering and unregistering duration histograms:
makeValueHistogram🙂unregisterValueHistogram🙂makeDurationHistogram🙂unregisterTimeHistogram🧐Modifications
unregisterTimeHistogramtounregisterDurationHistogram.Result
APIs more symmetrically named.
This is an API breaking change and I have not provided a backwards compatible shim and deprecation notice, because we are currently at 2.0.0-alpha.1 and SemVer permits API breaks at this stage.
However, I'm happy to update the patch to include the temporary shim, if we want to add it now, and remove before 2.0.0 release.