Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove some useless benchmarks #9880

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 15, 2025

Description:

I added this at the past because I wanted to know the performance implications of visitors and &dyn, but it's not require anymore and those benchmarks are creating useless comments combined with codspeed.

@kdy1 kdy1 added this to the Planned milestone Jan 15, 2025
@kdy1 kdy1 self-assigned this Jan 15, 2025
@kdy1 kdy1 requested a review from a team as a code owner January 15, 2025 07:47
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 15, 2025
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: 5aff7f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 merged commit 92fd3d2 into swc-project:main Jan 15, 2025
5 checks passed
@kdy1 kdy1 deleted the remove-some-bench branch January 15, 2025 07:48
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #9880 will degrade performances by 4.12%

Comparing kdy1:remove-some-bench (5aff7f9) with main (751a310)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 193 untouched benchmarks
⁉️ 9 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:remove-some-bench Change
es/full/minify/libraries/lodash 256.8 ms 247.8 ms +3.62%
es/minifier/libs/lodash 214.8 ms 224.1 ms -4.12%
es/minifier/libs/vue 238.1 ms 246.6 ms -3.42%
⁉️ es/visitor/base-perf/boxing_boxed 3.3 µs N/A N/A
⁉️ es/visitor/base-perf/boxing_boxed_clone 2.4 µs N/A N/A
⁉️ es/visitor/base-perf/boxing_unboxed 3.5 µs N/A N/A
⁉️ es/visitor/base-perf/boxing_unboxed_clone 2.6 µs N/A N/A
⁉️ es/visitor/base-perf/fold_empty 327.3 µs N/A N/A
⁉️ es/visitor/base-perf/fold_noop_impl_all 327.5 µs N/A N/A
⁉️ es/visitor/base-perf/fold_noop_impl_vec 327.4 µs N/A N/A
⁉️ es/visitor/base-perf/module_clone 326.9 µs N/A N/A
⁉️ es/visitor/base-perf/visit_contains_this 47.2 µs N/A N/A

@kdy1 kdy1 modified the milestones: Planned, 1.10.8 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant