Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(bench): Run benchmark on a custom runner #9877

Merged
merged 33 commits into from
Jan 14, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 14, 2025

Description:

I configured one custom runner using /~https://github.com/myoung34/docker-github-actions-runner that has 16 cores and 64GB RAM. It's much quieter than a public GitHub runner, so I'll rely on this for profiling.

@kdy1 kdy1 requested a review from a team as a code owner January 14, 2025 07:07
@kdy1 kdy1 self-assigned this Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: f48598a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
Copy link

codspeed-hq bot commented Jan 14, 2025

CodSpeed Performance Report

Merging #9877 will degrade performances by 5.12%

Comparing kdy1:custom-runner (f48598a) with main (3df8b44)

Summary

❌ 1 regressions
✅ 204 untouched benchmarks
⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:custom-runner Change
⁉️ bootstrap 64.7 ms N/A N/A
es/minifier/libs/moment 98.4 ms 103.7 ms -5.12%

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 14, 2025
@kdy1 kdy1 merged commit 2d6f9a5 into swc-project:main Jan 14, 2025
168 checks passed
@kdy1 kdy1 deleted the custom-runner branch January 14, 2025 19:37
@kdy1 kdy1 modified the milestones: Planned, 1.10.8 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant