Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(es/minifier): Improve parallelism and cache friendliness #9813

Merged
merged 9 commits into from
Jan 1, 2025
Merged

perf(es/minifier): Improve parallelism and cache friendliness #9813

merged 9 commits into from
Jan 1, 2025
+23 −16

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 26, 2024

Description:

  • Remove needless strcmp.

@kdy1 kdy1 added this to the Planned milestone Dec 26, 2024
@kdy1 kdy1 self-assigned this Dec 26, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2ee9007

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 26, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9813 will not alter performance

Comparing kdy1:min-rspack (2ee9007) with main (2307a4d)

Summary

✅ 194 untouched benchmarks

@kdy1 kdy1 mentioned this pull request Jan 1, 2025
Merged
@kdy1 kdy1 changed the title perf(es/minifier): Improve performance perf(es/minifier): Improve parallelism and cache friendlyness Jan 1, 2025
@kdy1 kdy1 marked this pull request as ready for review January 1, 2025 00:08
@kdy1 kdy1 requested review from a team as code owners January 1, 2025 00:08
@kdy1 kdy1 enabled auto-merge (squash) January 1, 2025 00:08
@kdy1 kdy1 changed the title perf(es/minifier): Improve parallelism and cache friendlyness perf(es/minifier): Improve parallelism and cache friendliness Jan 1, 2025
@kdy1 kdy1 disabled auto-merge January 1, 2025 00:10
@kdy1 kdy1 enabled auto-merge (squash) January 1, 2025 00:10
@kdy1 kdy1 merged commit f8dff56 into swc-project:main Jan 1, 2025
151 of 152 checks passed
@kdy1 kdy1 deleted the min-rspack branch January 1, 2025 00:39
kdy1 added a commit that referenced this pull request Jan 1, 2025
@kdy1
perf(es/minifier): Introduce FastJsWord and FastId in swc_atoms (…
ef0ec38 
…#9826)

**Description**:

`FastJsWord` and `FastId` implement `Copy` and do not need to be cloned or dropped, unlike `JsWord` or `Id`. Of course, they are inherently unsafe. But I found that I could use it for the minifier.


**Related issue:**

 - Extracted from #9813
@kdy1 kdy1 modified the milestones: Planned, v1.10.6 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.10.6
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1