Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Delay Wasm-plugin breaking changes #9735

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 11, 2024

@kdy1 kdy1 added this to the Planned milestone Nov 11, 2024
@kdy1 kdy1 self-assigned this Nov 11, 2024
Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: 9f743fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review November 11, 2024 14:11
@kdy1 kdy1 requested review from a team as code owners November 11, 2024 14:11
@kdy1 kdy1 merged commit 92faf5b into swc-project:main Nov 11, 2024
149 of 152 checks passed
@kdy1 kdy1 deleted the revert-bc branch November 11, 2024 14:12
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #9735 will degrade performances by 7.68%

Comparing kdy1:revert-bc (9f743fa) with main (c1d12d6)

Summary

❌ 7 regressions
✅ 187 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:revert-bc Change
es/full/all/es2015 185.2 ms 192.2 ms -3.62%
es/full/all/es2016 184 ms 190.5 ms -3.42%
es/full/all/es2017 183.2 ms 190 ms -3.57%
es/full/all/es2018 181.7 ms 188.2 ms -3.47%
es/full/all/es2019 180.8 ms 187.4 ms -3.5%
es/full/all/es2020 173.8 ms 180.7 ms -3.84%
es/full/parser 1.4 ms 1.5 ms -7.68%

@kdy1 kdy1 modified the milestones: Planned, 1.9.3 Nov 22, 2024
kdy1 added a commit to kdy1/swc that referenced this pull request Dec 2, 2024
kdy1 added a commit that referenced this pull request Dec 2, 2024
**Description:**

This reverts commit 92faf5b.

**Related issue:**

 - Reverts #9735
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant