perf(es/ast): Rollup merge of breaking changes #9180
Merged
+842,682
−1,256,375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
changed the title
kdy1
changed the title
CodSpeed Performance ReportMerging #9180 will degrade performances by 4.02%Comparing Summary
Benchmarks breakdown
|
**Description:** This PR changes the AST node construction code to use `.into()` or `::from()` to make changing the boxed-ness of the AST node easier. I used `ast-grep` to make large changes across codebase.
**Description:** This PR will help modifying boxedness of AST nodes.
![kodiakhq[bot]](/~https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
kdy1
changed the title
kdy1
commented
Jul 12, 2024
This was referenced Aug 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Span.ctxtis removed to reduce the size ofSpan.ctxt: SyntaxContextis added to various AST nodes.IdentNameis used instead ofIdentin some places likeMemberProp, because those fields does not needctxtoroptional.