Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/helpers): Allow using external helpers with type: module #4962

Merged
merged 7 commits into from
Jun 13, 2022
Merged

fix(es/helpers): Allow using external helpers with type: module #4962

merged 7 commits into from
Jun 13, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 13, 2022 •
edited
Loading

Description:

We use .mjs for imports, and common_js pass modifies .mjs imports to common js requires with patched path

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Jun 13, 2022
kdy1
kdy1 commented Jun 13, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_base
  • swc_ecma_transforms_compat

@kdy1 kdy1 changed the title fix(es/helpers): Allow using it with type: module fix(es/helpers): Allow using external helpers with type: module Jun 13, 2022
@kdy1 kdy1 marked this pull request as ready for review June 13, 2022 17:19
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 13, 2022
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) June 13, 2022 17:19
@kdy1 kdy1 merged commit 4a27e6f into swc-project:main Jun 13, 2022
@kdy1 kdy1 deleted the helpers branch June 13, 2022 18:41
@kdy1 kdy1 modified the milestones: Planned, v1.2.200, v1.2.201, v1.2.202, v1.2.203 Jun 14, 2022
@devongovett devongovett mentioned this pull request Jun 15, 2022
Merged
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.203
Development

Successfully merging this pull request may close these issues.

external helpers cannot be imported from projects with type: "module"
1 participant
@kdy1