Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scenario name as Goal dialog title #774

Merged
merged 2 commits into from
Oct 23, 2022

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Oct 23, 2022

part of #760

@kostmo kostmo requested a review from byorgey October 23, 2022 04:51
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

let goalModalTitle = case currentScenario of
Nothing -> "Goal"
Just (scenario, _) -> scenario ^. scenarioName
in (" " <> T.unpack goalModalTitle <> " ", Nothing, 80)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also often use the witch package to be able to write something like into @String instead of T.unpack.

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Oct 23, 2022
@mergify mergify bot merged commit 13e7dfe into main Oct 23, 2022
@mergify mergify bot deleted the issue-760-goal-dialog-scenario-title branch October 23, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants