Fix for issue #616 allOf fails to resolve RELATIVE ref #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #616
Issue #616 arises due to an unchecked use-case where one external file is referenced with respect to the
parentinstead of thesourcewhere the reference is made.Similar use-cases are handled correctly elsewhere but missed out in the case of
ComposedModels. This issue is specific to ComposedModel only i.e.allOf.The fix leverages existing
joinfunction to normalize and resolve the paths before sending it for processing the external definitions.CC: @tzimisce012 based on previous commits in this area.