Fixing composedSchema deserializing and resolving, allof, anyOf, Oneof #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phiz71
reviewed
Sep 8, 2017
| for(JsonNode n : allOfArray) { | ||
| if(n.isObject()) { | ||
| ComposedSchema allOfList = new ComposedSchema(); | ||
| schema = getSchema((ObjectNode) n,location,result); | ||
| allOfList.addAllOfItem(schema); | ||
| schema = allOfList; |
There was a problem hiding this comment.
schema = allOfList; : this line should be outside the for structure
phiz71
reviewed
Sep 8, 2017
| for(JsonNode n : anyOfArray) { | ||
| if(n.isObject()) { | ||
| ComposedSchema anyOfList = new ComposedSchema(); | ||
| schema = getSchema((ObjectNode) n,location,result); | ||
| anyOfList.addAnyOfItem(schema); | ||
| schema = anyOfList; |
There was a problem hiding this comment.
schema = anyOfList; : this line should be outside the for structure
|
I think the fixing of the |
|
hehe done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deserializing of composedSchema was only returning the last object of the arrays, and there were some issues in the resolving of this schemas.