Defect (Issue #445) : change the call of initialCaps for getter and setter proper generation #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etter with Introspector.decapitalize from pakage java.beans.
|
I have a question. I forgot to add some unit tests. |
|
You should be able to modify this PR with the added tests. |
fehguy
added a commit
that referenced
this pull request
Mar 4, 2015
Defect (Issue #445) : change the call of initialCaps for getter and setter proper generation
cchafer
added a commit
to cchafer/swagger-codegen
that referenced
this pull request
Mar 4, 2015
* commit '9ce4156e4cd1696b8758ed868fe3854ef19da2c9': Pull request swagger-api#452 : Add some unit tests for this PR Defect (Issue swagger-api#445) : change the call of initialCaps for getter and setter with Introspector.decapitalize from pakage java.beans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getter and Setter with 2nd chars being uppercase are not generated following the Sun specification : http://download.oracle.com/otn-pub/jcp/7224-javabeans-1.01-fr-spec-oth-JSpec/beans.101.pdf?AuthParam=1424762391_ef17a82335203d9fbf095a2f819eb317
Chapter 8.8.
When you generate a getter and setter, you should get :
fooBah --> getFooBah
mAttr --> getmAttr
That was not the cas, we got previously, which is wrong.
fooBah --> getFooBah
mAttr --> getMAttr
I have made a new function called getterAndSetterCapitalize which takes a String and return the proper capitalized name for getter and setter.