-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct composite builds #143
Conversation
@Goooler Thanks for the pull request. Would it be possible now to specify the Reveal dependencies in |
We have to move |
In commit afe6b08 I moved the demo app to a separate project. It was a subproject before. There was some reason why I did it but I don't remember. Maybe it was a build issue because of Kotlin Multiplatform, maybe it had something to do with the publication of the library. I don't know. |
Or we can let demo-app include build reveal-root, shared module now depends on core and shapes. |
2c34e17
to
ec183c5
Compare
I think I like that better. But instead of the substitutes, couldn't we directly use |
I'm not sure how to depend on composite build subprojects instead of module notations. |
- After this, it could be run from the root project. - AGP versions used by demo-app and the root project should be kept the same. - `includeBuild` phrases should be placed in `pluginManagement` block.
ec183c5
to
001c925
Compare
includeBuild
phrases should be placed inpluginManagement
block.