Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts #8956

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Update index.d.ts #8956

merged 4 commits into from
Feb 9, 2023

Conversation

0gust1
Copy link
Contributor

@0gust1 0gust1 commented Feb 8, 2023

Doc update attempt, following #8948.

Add precisions on version config option.

NB: I'm unsure of the correct doc formatting

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: /~https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Doc update attempt, following sveltejs#8948
Better formulation
@Rich-Harris Rich-Harris marked this pull request as ready for review February 9, 2023 00:07
@Rich-Harris Rich-Harris merged commit 0abb8eb into sveltejs:master Feb 9, 2023
@Rich-Harris
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants