Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix many links #6741

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Conversation

Conduitry
Copy link
Member

@Conduitry Conduitry commented Sep 11, 2022

These links were pointing to an anchor on this page that no longer exists.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: /~https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2022

🦋 Changeset detected

Latest commit: ffc8045

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member Author

Oh, I didn't realize these were published as part of the package and pulled in for the ambient types. I'll add a changeset.

@Conduitry Conduitry changed the title [docs] fix links from $env modules to env config [fix] fix links from $env modules to env config Sep 11, 2022
@Conduitry Conduitry changed the title [fix] fix links from $env modules to env config [fix] fix links from types to docs Sep 12, 2022
@Conduitry
Copy link
Member Author

I ran into some more broken links, and then tried to take a sweep through the repo for as many as I could find, and then added them on to this PR. We really gotta automate this. At some point I'm going to try looking into how this could happen during linting.

@benmccann benmccann merged commit 0e6a6d5 into sveltejs:master Sep 12, 2022
@Conduitry Conduitry deleted the env-docs-link-fix branch September 12, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants