-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: strip internal data before passing URL to reroute
#13092
Conversation
🦋 Changeset detectedLatest commit: bcecf13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
To clarify: If we merge this, then we need to adjust the referenced PR to also deal with this case, but it's not something that forces our hand in other places? |
We'd probably need to make the same adjustment if we need to run |
preview: https://svelte-dev-git-preview-kit-13092-svelte.vercel.app/ this is an automated message |
fixes #11625
This PR ensures that the
/__data.json
suffix,x-sveltekit-trailing-slash
, andx-sveltekit-invalidated
query param are stripped before passing a copy of the URL toreroute
so that the URL can be correctly rerouted instead of causing a 404 due to the/__data.json
pathname suffix.If this PR gets merged, we will need a shared solution for the edge middlewares running
reroute
in #12296Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits