fix: correctly include ambient types from adapters

[eltigerchino]

part of closing #11731
closes #12433

While investigating #11731 , I found that the ambient types from adapters weren't showing up when I tried installing the cloudflare, vercel, and node adapters in a fresh project and tried to access the autocomplete on event.platform. This is dependent on #12090 being merged first to get the types to show up in the IDE autocomplete.

This PR does the following:

* includes the svelte.config.js file in the generated tsconfig so that when the svelte.config.js file imports the adapter, the ambient types are included for the whole project. EDIT: separated into #12090
* references the worker types in the cloudflare adapters so that when the adapter is used, the project can access those types.

• standardises the naming of the files containing the internal adapter types and the ambient types we want included in the user's project when they add the adapter to the svelte config.
• includes the Vercel and Node ambient types in the package.json files array so users can get those types included automatically for their event.platform.

---

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: /~https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

• Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

[changeset-bot]

🦋 Changeset detected

Latest commit: 6242385

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@sveltejs/adapter-vercel	Patch
@sveltejs/adapter-node	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dummdidumm]

Inclusion of the Svelte config was reverted in #11908 because it's a breaking change strictly speaking. Is it ok to hold off from doing this until 3.0?

[eltigerchino]

Inclusion of the Svelte config was reverted in #11908 because it's a breaking change strictly speaking. Is it ok to hold off from doing this until 3.0?

Oh whoops. I didn’t realise it was something we already tried to do before.

Yeah, I think it’s fine to wait for 3.0 for this. It has an easy workaround (just include the types or reference the adapter in a declaration file). Maybe I can split the ambient declaration changes and the svelte config inclusion into separate PRs?

[eltigerchino]

note: it was suggested to not include the cloudflare types because they pollute the ambient types namespace.

[eltigerchino]

@benmccann is this a breaking change because of the additional types in the ambient namespace?

[benmccann]

Oh, I was confused because of the prior conversation on this PR (which seems to refer to a change that was dropped from this PR and moved to #12090) and because this PR was in the 3.0 milestone. I've taken it off the 3.0 milestone and removed the breaking change label

[eltigerchino]

cc: @gtm-nayan do you still think we should omit the worker types reference here to avoid polluting the ambient namespace?

[gtm-nayan]

Personally yes, but I should note that my usage of Cloudflare is only limited to a couple of projects so we could get more empirical.

Are the declarations limited to types or do they also add global variable and module declarations?

[eltigerchino]

I'm not entirely sure myself. @dario-piotrowicz what do you think about this? Are there any other frameworks doing this?

As an aside, I'm already getting them as ambient types because I have the drizzle orm d1 driver imported and they're doing this.

[eltigerchino]

I'm removing them from the ambient file since our docs already suggest to import them directly. https://svelte.dev/docs/kit/adapter-cloudflare#Runtime-APIs

[Rich-Harris]

preview: https://svelte-dev-git-preview-kit-12088-svelte.vercel.app/

this is an automated message

[dummdidumm]

looks good except one question