feat: add unit suffix support for BODY_SIZE_LIMIT
#11680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit suffixes support to the adapter-node
BODY_SIZE_LIMIT
environment variable.Currently, achieving large byte values is only achievable with the exact byte value, and using exponents (like
1e6
to be parsed by Number) results in a byte value in base 10.Nginx and Cloudflare both use base 2 for byte calculations (1024 based):
Nginx (source code): https://hg.nginx.org/nginx/file/default/src/core/ngx_parse.c
Cloudflare (forum question): https://community.cloudflare.com/t/is-max-upload-size-mb-1024-or-1000/239102
Adding unit suffixes to the byte values will make it easier to write and comprehend large byte values, as they can be written such as
100M
instead of104857600
Nginx also supports the size units
K
andM
(https://nginx.org/en/docs/syntax.html) so it would be relevant for Sveltekit to support these units as wellPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits