Move immutable and seamless-immutable to peer dependencies #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original discussion: #296
Currently, I use
connected-react-router
,redux-form
and the project doesn't depend onimmutable
at all. But it seems likeredux-form
is pretty eager forimmutable
library and if it presents insidenode_modules
it will be included in the bundle, which is pretty confusing. I'm not sure what was the purpose to includeimmutable
andseamless-immutable
in the library dependencies (keeping in mind that redux and react-router related stuff lives inpeerDependencies
), so these are breaking changes. Anyway everyone who wantsimmutable
orseamless-immutable
version of this package already has these packages installed, so it won't be a big issue for them to migrate.