[CI Test] Cronjob overhaul and added sunpydev #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @nabobalis! Everything looks great! |
nabobalis
commented
May 17, 2019
|
ndcube currently does fail on SunPy master. |
3 tasks
Cadair
reviewed
May 24, 2019
Cadair
approved these changes
May 24, 2019
|
Hi @nabobalis. As far as I can see, this looks good. Although I do notice that two of the tests are failing. Is that due to your changes or the fact that there may be incompatibilities of ndcube with sunpy-dev? |
|
It looks like that ndcube is not compatible with SunPy 1.0 (which sunpydev is testing) at the moment. |
|
That makes sense, in fairness. Well then if you an @Cadair are happy with it then I approve it too. |
DanRyanIrish
approved these changes
May 24, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
Clearly did a botch job the first time.
What milestone? Could be back ported to each version?