Fix password reset if SSO is enabled but not matched domain #7617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
changed the title
alexander-schranz
added
the
Bug
| @@ -92,7 +92,7 @@ public function onKernelRequest(RequestEvent $event): void | |||
|
|
|||
| $adapter = $this->singleSignOnAdapterProvider->getAdapterByDomain($domain); | |||
| if (!$adapter) { | |||
| if ($password) { | |||
| if ($password || $isResetPassword) { | |||
There was a problem hiding this comment.
Looks correct as we do the same on line 83. @martinlagler can you also check if all make sense here. I needed adopt some tests so not 100% sure if I did miss something.
There was a problem hiding this comment.
@alexander-schranz Also looks good to me, approved.
alexander-schranz
approved these changes
Oct 31, 2024
martinlagler
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Also check for reset route in the single sign on adapter.
Why?
Currently the password reset does not work.