Avoid __toString() return null error on Doctrine Exceptions #7478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
the
Bug
alexander-schranz
changed the title
Prokyonn
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Avoid __toString() on doctrine Exceptions.
Why?
If a
DoctrineException happen doctrine tries to call$entity->__toString()method for generating the error message. But as in some cases the Tag Name is may not set it ends up in the error:Most devs confused that and not looking at the
Stack Traceof the error to get the real error message. To avoid this error we should always return a string if possible.For 3.0 I would recommend to remove the magic methods so doctrine returns always the object hash, but that is a bc break at current state, so need to discussed first.