Fix smartcontent properties and page selection for non exist properties #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
bugfix/smartcontent-non-exist-property
branch
3 times, most recently
from
6c4fc76 to
c9ece7d
Compare
alexander-schranz
changed the title
| @@ -76,12 +76,14 @@ public function resolve($data, PropertyInterface $property, string $locale, arra | |||
| 'published' => !$this->showDrafts, | |||
| ]); | |||
|
|
|||
| list($pagesQuery) = $this->contentQueryBuilder->build($property->getStructure()->getWebspaceKey(), [$locale]); | |||
| $webspaceKey = $property->getStructure() ? $property->getStructure()->getWebspaceKey() : null; | |||
There was a problem hiding this comment.
Not sure about this change. We would need some reproducable here why this change is required I currently can not reproduce it.
There was a problem hiding this comment.
/cc @thomasduenser I removed currently this change unless we have something to reproduce so we can atleast merge the other fix
alexander-schranz
force-pushed
the
bugfix/smartcontent-non-exist-property
branch
from
c9ece7d to
bb08c6e
Compare
alexander-schranz
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues: