Replace ETA with delay #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using delays, converting to an ETA, and then back to a duration effectively floors the delay.
| @@ -5,29 +5,8 @@ import ( | |||
| "time" | |||
| ) | |||
|
|
|||
| // ErrRetryTaskLater ... | |||
| type ErrRetryTaskLater struct { | |||
There was a problem hiding this comment.
We no longer use ErrRetryTaskLater -- we always use ErrKeepAndRetryTaskLater
rw-access
approved these changes
Jun 7, 2024
| return ErrRetryTaskLater{msg: msg, retryIn: retryIn} | ||
| } | ||
|
|
||
| // Retriable is interface that retriable errors should implement |
There was a problem hiding this comment.
thanks for fixing this cursed word most of all
There was a problem hiding this comment.
I thought that I'd invented this spelling and was sitting here wondering what was wrong with me, but I just checked and it actually wasn't me and I feel a whole lot better about myself now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using delays, converting to an ETA, and then back to a duration effectively floors the delay.