Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'U' mode from Python open() function #2171

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

TripleRider
Copy link
Contributor

Proposed Changes

Remove use of 'U' mode from Python open() function in TestCase.py.

Related Work

Issue #2170. Identifies test case that didn't run from serial_regression.py.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted
Copy link
Contributor

Thanks, please add yourself to the authors list in AUTHORS.md as well.

@bigfooted bigfooted merged commit 843606a into su2code:develop Nov 23, 2023
30 of 31 checks passed
@TripleRider TripleRider deleted the fix_testcase_file_mode branch November 27, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants