Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Cur_Time column to the default history field for transient analysis; #2141

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

getwelsim
Copy link

Proposed Changes

add Cur_Time column to the default history.csv file for transient analysis

Related Work

I propose this change mainly for third-party post-processing purposes, the post module can easily acquire the time information from the history file. In addition, the time data in the history file allows the users to know the current simulation time intuitively.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like Iter, cur_time, and rms_res are common to all output classes now. Add a common function in COutput to keep this consistent across output classes please.

@lcheng9
Copy link
Contributor

lcheng9 commented Sep 30, 2023

Thank you for the comments @pcarruscag. I will try to make a common function for Iter, cur_time, and rms_res.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 add yourself to AUTHORS.md please

@lcheng9
Copy link
Contributor

lcheng9 commented Oct 4, 2023

Thank you for approving the changes. The name is just added.

@pcarruscag pcarruscag merged commit 41d2522 into su2code:develop Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants