Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding V&V case compos. dep. model to test cases. #2100

Merged
merged 4 commits into from
Aug 6, 2023

Conversation

sjhbtue
Copy link

@sjhbtue sjhbtue commented Aug 3, 2023

Proposed Changes

Re-adding required files for test case VV sandia jet and changed regression.yml to get residual values required for vandv.py
@bigfooted @Cristopher-Morales. (This PR is created to get the residual values for the vandv.py script.)

Related Work

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@sjhbtue
Copy link
Author

sjhbtue commented Aug 4, 2023

@pcarruscag In this PR, I have a problem with running the regression tests, because it can not find my branch, as can be seen in the figure below:
image
I believe it might be related to the fact that I'm creating a PR from a created fork of the SU2 repository, instead of just having an own branch in the su2code/SU2 repository. So, the branch I'm in is located in sjhbtue/SU2. Could this indeed be the problem or do you think I can still solve it in a different way? Thanks in advance!

TestCases/vandv.py Outdated Show resolved Hide resolved
@pcarruscag pcarruscag merged commit 7bdc705 into su2code:develop Aug 6, 2023
@sjhbtue
Copy link
Author

sjhbtue commented Aug 6, 2023

Thank you! @pcarruscag @Cristopher-Morales

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants