Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid Parallel AD Fixes #2046

Merged
merged 3 commits into from
May 31, 2023
Merged

Hybrid Parallel AD Fixes #2046

merged 3 commits into from
May 31, 2023

Conversation

jblueh
Copy link
Contributor

@jblueh jblueh commented May 31, 2023

Proposed Changes

Small follow-on from #2039. Fixes two data races that did not affect the results but polluted the thread sanitizer findings (write-write for value that is not read and read-write for value that is overwritten with itself).

Related Work

#2039

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh merged commit 690b81a into develop May 31, 2023
@jblueh jblueh deleted the hybrid_parallel_ad_fixes branch May 31, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants