Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoDiPack 2 Update #1903

Merged
merged 26 commits into from
Mar 14, 2023
Merged

CoDiPack 2 Update #1903

merged 26 commits into from
Mar 14, 2023

Conversation

jblueh
Copy link
Contributor

@jblueh jblueh commented Jan 31, 2023

Proposed Changes

Update SU2 to a recent version of CoDiPack.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh changed the title [WIP] CoDiPack 2 Update CoDiPack 2 Update Mar 2, 2023
@jblueh
Copy link
Contributor Author

jblueh commented Mar 2, 2023

The changes to SU2 are mostly minor. There are some adaptions regarding external functions, due to interface changes from CoDiPack 1 to CoDiPack 2. The callPrimalFuncWithADType is necessary for correct output handling. Passing the external function to it is the intended usage, therefore the encapsulation of the respective code block in a lambda expression. callPrimalFuncWithADType also takes care of the tape activity, which was previously spelled out in SU2.

@jblueh jblueh merged commit b5d861c into develop Mar 14, 2023
@jblueh jblueh deleted the codipack_2_update branch March 14, 2023 18:25
@jblueh jblueh mentioned this pull request Apr 11, 2023
5 tasks
@jblueh jblueh mentioned this pull request Apr 19, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants