Consistent mass fluxes between bulk flow and scalar solvers and boundedness correction #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffects of nonzero flow divergence on the scalar solver residual
…ffects of nonzero flow divergence on the scalar solver residual
pcarruscag
reviewed
Jul 4, 2022
pcarruscag
reviewed
Jul 4, 2022
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
…hod which enables the correction terms to negate the effects of flow divergence on the scalar solution
…hod which enables the correction terms to negate the effects of flow divergence on the scalar solution
bigfooted
commented
Jul 28, 2022
pcarruscag
reviewed
Sep 9, 2022
…or the compressible Euler solver
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
|
@EvertBunschoten, are there any known TO-DO's for this PR besides updating the regression test? |
pcarruscag
requested changes
Nov 21, 2022
pcarruscag
reviewed
Nov 22, 2022
…ies solutions to use inlet and outlet characteristic flow variables instead of the local flow variables when computing the mass flux.
|
…discretization, bounded scalars not compatible with compressible flows, fix formatting and trailing spaces
pcarruscag
reviewed
Nov 25, 2022
pcarruscag
reviewed
Nov 25, 2022
pcarruscag
changed the title
pcarruscag
approved these changes
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
We need a different treatment of the convective scalar fluxes to improve results for the species solver.
This PR deals with the specific case of the incompressible species solver.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
connected to #726 and #721, and discussion #1695
my checklist:
[] check residual convergence for old and new testcase (primitive venturi mixer)
[] check convergence for turbulence problems, still problematic? Should we implement upwind scheme for species only (for now)?
[] check implementation of inlet/outlet bc
[] compressible flow vs incompressible flow
[]
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.