Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for a call to LoadUnsteady_Solution in CDiscAdjFluidIteration::Preprocess #1638

Merged
merged 2 commits into from
May 19, 2022

Conversation

MaxSagebaum
Copy link
Contributor

The parameters in iInst and iZone are swapped which gives a segmentation fault for adjoint HB computations.

…:Preprocess.

The arguments of iZone and iInst were swapped.
@pcarruscag pcarruscag changed the base branch from master to develop May 18, 2022 13:09
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max, seems that we have that mistake also in lines 150 and 152, can you update them please?

@MaxSagebaum
Copy link
Contributor Author

Sure, actually I looked at other places but have missed these.

Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix Max 💐

@pcarruscag pcarruscag merged commit da4c75d into su2code:develop May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants