Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix supersonic inflow/outflow for turbulence and passive scalar solvers #1554

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Fix supersonic inflow/outflow for turbulence and passive scalar solvers #1554

merged 1 commit into from
Mar 4, 2022

Conversation

pcarruscag
Copy link
Member

I have a v&v test baking for this which I'll add in another PR

TobiKattmann
TobiKattmann approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looking forward to the testcase :)

@pcarruscag pcarruscag merged commit 52f8d89 into develop Mar 4, 2022
@pcarruscag pcarruscag deleted the fix_supersonic_inflow_outflow_of_scalars branch March 4, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiKattmann TobiKattmann TobiKattmann approved these changes

Assignees
No one assigned
Labels
changelog:fix PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcarruscag @TobiKattmann