Fix adjoint MUSCL species bug

[bigfooted]

Proposed Changes

change limiter to enum class.

Note: For some reason this fixes a problem for the species transport, where the discrete adjoint solver would stop in computelimiters.hpp with the message "unknown limiter type". This only happens when a computation is run over more than one node (more than one core is OK though). This is because in CSolver::SetSolution_Limiter, GetKind_SlopeLimit() does not return a valid value for an existing slope limiter. Kind_SlopeLimit is set in CConfig::SetKind_ConvNumScheme, called in CConfig::SetGlobalParam, but this looks OK to me.

I did just notice that in CConfig:: line 3454 we check for MUSCL_Flow, MUSCL_Turb and MUSCL_AdjFlow and MUSCL_AdjTurb, but not for MUSCL_Species or MUSCL_Adj_Species(does not even exist). It looks like there is still something missing here.

I do not know why the error "unknown limiter type" occured and why it is now fixed by only changing to enum class.

Related Work

continuing effort to change all enums to enum class

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

• I am submitting my contribution to the develop branch.
• My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
• My contribution is commented and consistent with SU2 style.
• I have added a test case that demonstrates my contribution, if necessary.
• I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

[TobiKattmann]

Thanks @bigfooted for enum class-ing the limiters 💐

I also dont know how and why this fixes the problem you saw but I would also suspect that this doesnt solve the root-cause. So valgrinding a DA case with species limiters would be nice. But in CConfig.cpp::3454 I would certainly add KindSLopeLimit_Species=NONE if !MUSCL_Species. On that note: Did your case had MUSCL_SPECIES with limiters on or off?

[bigfooted]

the valgrind message has been solved by the most recent commit

[bigfooted]

@pcarruscag When running SU2_CFD_AD, the solver is DISC_ADJ_INC_RANS, and a number of initializations are skipped when we do not include this check. Most notably setting kind_limiter, which then leads to the 'conditional depends on uninitialized value' message from valgrind.