You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces a series of regression cases for the Spalart-Allmaras turbulence model variations and corrections:
Baseline
Negative
Edwards
Compressibility
Compressibility and Edwards
QCR2000
The residuals on the python scripts are wrong. These values are temporary and will be updated once the regression tests are run on the Travis CI system.
Since this pull request does not introduce any code modification, the residuals on the python scripts have been updated on commit 1a1661f with the Travis Cl (sim_vals (computed)) values.
Related Work
These tests will be further used to verify the correct implementation of #1413
I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.
As stated in #1384 some hybrid parallel AD regression tests failed.
The regression test visc_cone has also failed with ERROR: The code was not able to get to the "Begin solver" section. for both serial_regression.py and parallel_regression.py.
…nfig files
Remove the turbulence models serial regression tests. Left only parallel tests.
Strip all the comments and non relevant options from the config files
Thanks for this +1 Please strip all the comments and non relevant options from the configs.
Thank you Pedro for all your suggestions.
I have reverted the serial_regression.py file and updated the configuration files. This work is done in 84c9584.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
suargi
changed the title
pcarruscag
changed the title
Pull request description
This pull request introduces a series of regression cases for the Spalart-Allmaras turbulence model variations and corrections:
The residuals on the python scripts are wrong. These values are temporary and will be updated once the regression tests are run on the Travis CI system.Since this pull request does not introduce any code modification, the residuals on the python scripts have been updated on commit 1a1661f with the Travis Cl (sim_vals (computed)) values.
Related Work
These tests will be further used to verify the correct implementation of #1413