Cleanup in NEMO #1389
Merged
Cleanup in NEMO #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jtneedels <jneedels@stanford.edu>
pcarruscag
approved these changes
Oct 3, 2021
TobiKattmann
reviewed
Oct 4, 2021
| @@ -336,5 +328,4 @@ CNumerics::ResidualType<> CAvgGradCorrected_NEMO::ComputeResidual(const CConfig | |||
| } | |||
|
|
|||
| return ResidualType<>(Flux, nullptr, nullptr); | |||
| } | |||
|
|
|||
| } | |||
There was a problem hiding this comment.
I am not sure whether there are negative consequences of not having a newline at the end of the file, but if GitHub warns about this one might as well just add a newline :)
There was a problem hiding this comment.
Yes good point, it looks like this is mainly to differentiate a file with/without the newline in the diff, but I guess can also cause issues in some cases if files are concatenated. I'm going to open up a second PR to clean up the NEMO convective schemes, I'll address this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jtneedels jneedels@stanford.edu
Proposed Changes
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.