Cleanup wall functions and add user controls #1360

bigfooted · 2021-08-24T09:51:43Z

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

fixed a small bug in the wall model
added config options (replace as many hard coded constants as possible)
aerodynamic heating (wall temperature imposed in compressible flow, still needs a high mach testcase)
added a test case for SA model
cleaned up a bit

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

…to fix_wallfunctions

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

refvel Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

const bool Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

…to fix_wallfunctions

away with the comment blocks! Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

…to fix_wallfunctions

TestCases/serial_regression.py

…into fix_wallfunctions

SU2_CFD/src/solvers/CNSSolver.cpp

TobiKattmann · 2021-10-07T12:50:22Z

Changes that are necessary in a follow-up PR:

Move regression tests to parallel regression and hybrid reg. Maybe the 4 cases can be split over those.
Find similarities between IncNS and NS TauWallWF implementation and make it a common implementation.

Please add to this post other things (I am fine with others editing this)

Common/src/CConfig.cpp

TobiKattmann · 2021-10-16T12:39:21Z

i made a little Test for the Non-dimensionalization: Turns out the inc Testcases did not specify INC_NONDIM where the default is INITIAL_VALUES. I will specify that for the reg tests.

I think the non-dim is currently correct: attached the incomp-SA case comparison INITIAL_VALUES against DIMENSIONAL.

Here the non-dim value is dimensionalized using what gets printed in the screen output

TobiKattmann · 2021-10-16T13:56:06Z

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

+
+      if (!wallfunctions) {
+        YPlus[iMarker][iVertex] = WallDistMod * FrictionVel / (Viscosity / Density);
+      }


This change made the comp SST WF reg test fail. There are no changes for the inc SST case and the SA cases, though.

pcarruscag · 2021-10-16T15:07:53Z

SU2_CFD/src/solvers/CTurbSSTSolver.cpp

-    if (Y_Plus < 5.0) continue;
+    if (Y_Plus < minYPlus) {
+      /* --- Use zero flux (Neumann) conditions, i.e. nothing has to be done. --- */
+      continue;
+    }


That might be a positive change @TobiKattmann, the recomputation of y+ could be interfering with the logic here, affecting the boundary conditions of the turb solver.

TestCases/serial_regression.py

…into fix_wallfunctions

TobiKattmann · 2021-10-20T07:52:15Z

TestCases/serial_regression.py

@@ -321,7 +321,7 @@ def main():
    turb_wallfunction_flatplate_sst.cfg_dir   = "wallfunctions/flatplate/compressible_SST"
    turb_wallfunction_flatplate_sst.cfg_file  = "turb_SST_flatplate.cfg"
    turb_wallfunction_flatplate_sst.test_iter = 10
-    turb_wallfunction_flatplate_sst.test_vals = [-4.230000, -1.930543, -1.998684, 1.250334, -1.635534,  1.462491, 10, -2.151894, 0.072872, 0.002514] #last 10 columns
+    turb_wallfunction_flatplate_sst.test_vals = [-4.229955, -1.930560, -1.998477, 1.250383, -1.635663, 1.462396, 10.000000, -2.151959, 0.072873, 0.002514] #last 10 columns


Thanks for this "final" addition and all the help on this (where of course @bigfooted did the heavy lifting ;) )

Now this is good to go from my perspective, I have no further comments. Maybe we can merge this in todays dev meeting :)

Things tbd in the future are

consolidate compr and inc implementation into some unified entitiy

Distribute Testcases over parallel, hybrid regression test

explanation on the website, tutorial

Alright merging this in now ✈️

TobiKattmann · 2021-11-10T15:17:11Z

See #1430 for some more things to fix

bigfooted and others added 30 commits February 21, 2021 09:18

fixed wall functions for SA and SST

e5e5d19

cleaning up wall model implementation

6be5670

cleaning up wall model implementation

a62a0b8

cleaning up wall model implementation

ecc7d3f

Merge branch 'develop' into fix_wallfunctions

f643214

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

3705941

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

merge develop back in

25fd773

cleanup based on code review

cc1798f

Merge branch 'fix_wallfunctions' of /~https://github.com/su2code/SU2 in…

e17af6d

…to fix_wallfunctions

Merge branch 'develop' into fix_wallfunctions

76a14b2

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

dbde0f7

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

8e4c4b8

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.hpp

f7972ae

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

b15e5f9

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

f3551d8

refvel Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

51da480

const bool Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

f3f7139

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/src/solvers/CTurbSSTSolver.cpp

de8f6cd

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CIncNSSolver.hpp

ae7687e

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

small update

7b61985

Merge branch 'fix_wallfunctions' of /~https://github.com/su2code/SU2 in…

3e996bd

…to fix_wallfunctions

Merge branch 'develop' into fix_wallfunctions

9437a11

Update SU2_CFD/include/solvers/CSolver.hpp

658e7cb

away with the comment blocks! Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

fix unused variables update

ae47196

Merge branch 'fix_wallfunctions' of /~https://github.com/su2code/SU2 in…

06898d6

…to fix_wallfunctions

fix unused variables update

69e7fe1

fix wall model constant config option

6d629c8

fixed alignment and missing break statement

0c0e3e6

computing skinfriction when y+ < 5

fa88243

Merge remote-tracking branch 'upstream/develop' into develop

db32076

pr-triage bot added the PR: reviewed-approved label Oct 7, 2021

pcarruscag reviewed Oct 7, 2021

View reviewed changes

TestCases/serial_regression.py Outdated Show resolved Hide resolved

TobiKattmann added 2 commits October 7, 2021 14:41

Minor changes. Comments and moved variable.

d3b2fed

Merge branch 'fix_wallfunctions' of /~https://github.com/bigfooted/SU2 …

b0bcd88

…into fix_wallfunctions

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels Oct 7, 2021

TobiKattmann reviewed Oct 7, 2021

View reviewed changes

SU2_CFD/src/solvers/CNSSolver.cpp Show resolved Hide resolved

TobiKattmann approved these changes Oct 7, 2021

View reviewed changes

pcarruscag and others added 3 commits October 8, 2021 10:01

Merge branch 'develop' into fix_wallfunctions

7a7194c

Merge remote-tracking branch 'origin/develop' into fix_wallfunctions

7d0a480

Merge remote-tracking branch 'origin/develop' into fix_wallfunctions

17e52ea

TobiKattmann reviewed Oct 14, 2021

View reviewed changes

Common/src/CConfig.cpp Outdated Show resolved Hide resolved

do not recompute y+ when wall functions are used

dd8d981

TobiKattmann reviewed Oct 16, 2021

View reviewed changes

Update cfg files. Cleaning + formatting.

b9e83e7

pcarruscag reviewed Oct 16, 2021

View reviewed changes

Merge branch 'develop' into fix_wallfunctions

e35cfeb

pcarruscag reviewed Oct 19, 2021

View reviewed changes

TestCases/serial_regression.py Outdated Show resolved Hide resolved

pcarruscag and others added 5 commits October 19, 2021 11:47

Update TestCases/serial_regression.py

af850b9

Merge remote-tracking branch 'origin/develop' into fix_wallfunctions

0111ebb

Merge branch 'fix_wallfunctions' of /~https://github.com/bigfooted/SU2 …

9a3804a

…into fix_wallfunctions

Merge remote-tracking branch 'origin/develop' into fix_wallfunctions

f9a5129

Do some checks for the wall function impl in CConfig.

d492fb4

TobiKattmann reviewed Oct 20, 2021

View reviewed changes

TobiKattmann merged commit 93f78c4 into su2code:develop Oct 20, 2021

pr-triage bot added PR: merged and removed PR: unreviewed labels Oct 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup wall functions and add user controls #1360

Cleanup wall functions and add user controls #1360

bigfooted commented Aug 24, 2021

TobiKattmann commented Oct 7, 2021

TobiKattmann commented Oct 16, 2021

TobiKattmann Oct 16, 2021

pcarruscag Oct 16, 2021

TobiKattmann Oct 20, 2021

TobiKattmann Oct 20, 2021

TobiKattmann commented Nov 10, 2021 •

edited

Loading

Cleanup wall functions and add user controls #1360

Cleanup wall functions and add user controls #1360

Conversation

bigfooted commented Aug 24, 2021

Proposed Changes

Related Work

PR Checklist

TobiKattmann commented Oct 7, 2021

TobiKattmann commented Oct 16, 2021

TobiKattmann Oct 16, 2021

Choose a reason for hiding this comment

pcarruscag Oct 16, 2021

Choose a reason for hiding this comment

TobiKattmann Oct 20, 2021

Choose a reason for hiding this comment

TobiKattmann Oct 20, 2021

Choose a reason for hiding this comment

TobiKattmann commented Nov 10, 2021 • edited Loading

TobiKattmann commented Nov 10, 2021 •

edited

Loading