Fix SA and SST wall functions #1204

bigfooted · 2021-02-22T21:31:05Z

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

Fixes (I think) the current implementation of the wall model. Some work still needs to be done, regarding compressible vs incompressible and validation of heated walls.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

related to #1155
Also took some ideas from feature_WallModelLES

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

[ x] I am submitting my contribution to the develop branch.
[ x] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

TobiKattmann

Hi, just a few things from scrolling through the code. But I like that you stay close to the given paper and also sometimes give equation numbers. Otherwise there is still a lot of commented code but that's what WIP is for ;)

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

SU2_CFD/src/solvers/CIncNSSolver.cpp

SU2_CFD/src/solvers/CTurbSSTSolver.cpp

pcarruscag

Yey wall functions. I know it is still WIP but few comments below.

SU2_CFD/include/solvers/CFVMFlowSolverBase.hpp

SU2_CFD/include/solvers/CSolver.hpp

pcarruscag · 2021-02-23T10:32:14Z

SU2_CFD/src/numerics/flow/flow_sources.cpp

    du_gust_dy = WindGustDer_i[1];
+    //du_gust_dz = WindGustDer_i[2];
    du_gust_dt = WindGustDer_i[2];


kudos for picking up "feature requests" from CFD online 👍

Did you ever check if the 3D version worked? Otherwise we gained deadcode for no reason...

SU2_CFD/src/solvers/CIncNSSolver.cpp

SU2_CFD/src/solvers/CTurbSSTSolver.cpp

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

…to fix_wallfunctions

update master

bigfooted · 2021-03-02T20:43:18Z

I updated the code based on your comments. I have to rerun the validation test case that I have to see if it still matches with the experimental data. I also have to check the compressible vs incompressible implementation.

SU2_CFD/include/solvers/CFVMFlowSolverBase.hpp

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

SU2_CFD/src/solvers/CIncNSSolver.cpp

SU2_CFD/src/solvers/CNSSolver.cpp

SU2_CFD/src/solvers/CTurbSASolver.cpp

SU2_CFD/src/solvers/CTurbSSTSolver.cpp

pcarruscag · 2021-03-02T21:18:41Z

Thanks @bigfooted, I fixed the conflicts (albeit not very well judging from the broken compilation) and left some more comments some more important than others.
For me the most important ones are those regarding avoiding any and all repetition, reference factors and so on.

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

SU2_CFD/src/solvers/CTurbSASolver.cpp

SU2_CFD/src/solvers/CTurbSSTSolver.cpp

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

refvel Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

const bool Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

.vscode/launch.json

pcarruscag · 2021-05-19T21:27:01Z

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

+  /*--- Wall shear stress values (wall functions) ---*/
+
+  numerics->SetTauWall(nodes->GetTauWall(iPoint),
+                       nodes->GetTauWall(jPoint));


Please add or modify some test cases (comp and incomp) I will need to modify the vectorized numerics to support this and it would be helpful to have a good reference.

OK, I have the flat plate test case for this (Schubauer & Klebanoff), will add this

config_template.cfg

TestCases/py_wrapper/flatPlate_unsteady_CHT/unsteady_CHT_FlatPlate_Conf.cfg

config_template.cfg

…to fix_wallfunctions

pcarruscag · 2021-05-29T22:59:53Z

SU2_CFD/src/numerics/flow/flow_diffusion.cpp

-  SetStressTensor(Mean_PrimVar, Mean_GradPrimVar, Mean_turb_ke, Mean_Laminar_Viscosity, Mean_Eddy_Viscosity);
+  SetStressTensor(Mean_PrimVar, Mean_GradPrimVar, Mean_turb_ke,
+                  Mean_Laminar_Viscosity, Mean_Eddy_Viscosity);
+  if (config->GetQCR()) AddQCR(nDim, &Mean_GradPrimVar[1], tau);
+  if (Mean_TauWall > 0) AddTauWall(UnitNormal, Mean_TauWall);


I've been looking into making the wall functions compatible with the vectorized classes.
I got confused, however, because it looks like the tau wall was not considered in the incompressible viscous numerics.
But your validation results looked good... So, either this makes them better, or it is not needed (here and in the other 2 viscous classes that use it).

In #1120 @EduardoMolina also added the "tau wall logic" to the incompressible class but he changed the implementation in the 3 classes to only consider tau wall if only one of the two points has it.
Which means that for edges connecting two wall points tau wall is not considered... might be worth re-running some tests?

I think in the case of RANS wall functions, the tauwall values that you mention are always overwritten by the tauwall computed at the end of CIncNSSolver::SetTauWall_WF(..). The function addtauwall is used only for the LES implementation.

Tau wall is computed in that function as part of the preprocessing, to then be used in the numerics, I don't see any other place in the code where the computed tau wall can influence the solution.

… vectorized implementation

pcarruscag

Just that test case to go I guess.

pcarruscag · 2021-06-15T13:06:23Z

SU2_CFD/src/solvers/CIncNSSolver.cpp

            notConvergedCounter++;
-            cout << "Warning: Y+ did not converge within the max number of iterations!" << endl;


I was trying this on the CRM and these messages were showing up a lot, so I made some changes to print only one message with totals.
I also copied the "safe values" you had for the compressible version.

Hi Pedro, Yes, they are present only for the first 10 iterations or so usually. Maybe we can introduce verbosity levels for such messages.

pcarruscag · 2021-06-15T13:10:56Z

SU2_CFD/src/solvers/CNSSolver.cpp

-      if (Y_Plus_Start < 5.0) {
-        cout << "skipping stress due to wall model" << endl;
-        continue;
+      if (Y_Plus_Start < Y_Plus) {
+        skipCounter++;
      }
-
-      while (fabs(diff) > tol) {
+      else while (fabs(diff) > tol) {


I also made this logic the same as the incomp solver, it seemed that certain quantities would not be computed otherwise.
Hopefully this was the right thing to do and not the opposite.

bigfooted · 2021-06-22T07:04:22Z

Thanks @pcarruscag and @TobiKattmann ! I will add the testcase and some small things in a new PR!

bigfooted added 4 commits February 21, 2021 09:18

fixed wall functions for SA and SST

e5e5d19

cleaning up wall model implementation

6be5670

cleaning up wall model implementation

a62a0b8

cleaning up wall model implementation

ecc7d3f

pr-triage bot added the PR: draft label Feb 22, 2021

Merge branch 'develop' into fix_wallfunctions

f643214

TobiKattmann reviewed Feb 23, 2021

View reviewed changes

pcarruscag reviewed Feb 23, 2021

View reviewed changes

bigfooted commented Feb 23, 2021

View reviewed changes

SU2_CFD/src/solvers/CTurbSSTSolver.cpp Outdated Show resolved Hide resolved

bigfooted and others added 2 commits February 24, 2021 13:36

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

3705941

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

merge develop back in

25fd773

pcarruscag added the changelog:feature label Feb 25, 2021

bigfooted and others added 3 commits March 2, 2021 11:50

cleanup based on code review

cc1798f

Merge branch 'fix_wallfunctions' of /~https://github.com/su2code/SU2 in…

e17af6d

…to fix_wallfunctions

Merge pull request #1216 from su2code/develop

ce07d5c

update master

Merge branch 'develop' into fix_wallfunctions

76a14b2

pcarruscag reviewed Mar 2, 2021

View reviewed changes

bigfooted and others added 2 commits March 3, 2021 07:42

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

dbde0f7

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

8e4c4b8

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

pcarruscag reviewed Mar 3, 2021

View reviewed changes

SU2_CFD/src/solvers/CTurbSASolver.cpp Outdated Show resolved Hide resolved

pcarruscag reviewed Mar 3, 2021

View reviewed changes

SU2_CFD/src/solvers/CTurbSSTSolver.cpp Outdated Show resolved Hide resolved

bigfooted and others added 6 commits March 3, 2021 14:13

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.hpp

f7972ae

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

b15e5f9

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

f3551d8

refvel Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

51da480

const bool Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

f3f7139

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/src/solvers/CTurbSSTSolver.cpp

de8f6cd

spaces Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

pcarruscag reviewed May 19, 2021

View reviewed changes

.vscode/launch.json Outdated Show resolved Hide resolved

pcarruscag reviewed May 19, 2021

View reviewed changes

bigfooted removed the PR: draft label May 21, 2021

bigfooted marked this pull request as ready for review May 21, 2021 13:15

pr-triage bot added the PR: unreviewed label May 21, 2021

bigfooted and others added 3 commits May 21, 2021 15:18

remove vscode

e32750f

Update SU2_CFD/include/solvers/CTurbSSTSolver.hpp

c33db7c

Merge branch 'hybrid_parallel_ad3' into fix_wallfunctions

722f3bb

pcarruscag reviewed May 29, 2021

View reviewed changes

config_template.cfg Outdated Show resolved Hide resolved

TestCases/py_wrapper/flatPlate_unsteady_CHT/unsteady_CHT_FlatPlate_Conf.cfg Outdated Show resolved Hide resolved

config_template.cfg Outdated Show resolved Hide resolved

pcarruscag and others added 5 commits May 29, 2021 14:54

Apply suggestions from code review

dabd9ee

Merge branch 'fix_wallfunctions' of /~https://github.com/su2code/SU2 in…

af96967

…to fix_wallfunctions

small cleanup

a626425

Merge remote-tracking branch 'upstream/develop' into fix_wallfunctions

ea38fd5

a little more refactoring

a5a5835

pcarruscag reviewed May 29, 2021

View reviewed changes

pcarruscag and others added 4 commits May 30, 2021 15:34

apply fix from #1120 (do not consider tau wall for edges along wall),…

fb3c0cc

… vectorized implementation

Merge remote-tracking branch 'upstream/develop' into fix_wallfunctions

557b950

some fixes and better warnings

90723af

Merge branch 'develop' into fix_wallfunctions

7ab705c

pcarruscag approved these changes Jun 15, 2021

View reviewed changes

bigfooted merged commit 350fee9 into develop Jun 22, 2021

bigfooted deleted the fix_wallfunctions branch June 22, 2021 07:03

pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 22, 2021

pr-triage bot added PR: unreviewed and removed PR: merged labels Jun 25, 2021

maxaehle mentioned this pull request Sep 17, 2021

Register TauWall as preaccumulation input #1374

Merged

5 tasks

pcarruscag mentioned this pull request Jan 23, 2022

MAJOR ISSUES / DEVELOPMENT AREAS #1487

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix SA and SST wall functions #1204

Fix SA and SST wall functions #1204

bigfooted commented Feb 22, 2021 •

edited

Loading

TobiKattmann left a comment

pcarruscag left a comment

pcarruscag Feb 23, 2021

bigfooted Feb 23, 2021

pcarruscag Jun 25, 2021

bigfooted commented Mar 2, 2021

pcarruscag commented Mar 2, 2021

pcarruscag May 19, 2021

bigfooted May 21, 2021

pcarruscag May 29, 2021

pcarruscag May 29, 2021

bigfooted May 31, 2021

pcarruscag May 31, 2021

pcarruscag left a comment

pcarruscag Jun 15, 2021

bigfooted Jun 15, 2021

pcarruscag Jun 15, 2021

bigfooted commented Jun 22, 2021

		notConvergedCounter++;
		cout << "Warning: Y+ did not converge within the max number of iterations!" << endl;

Fix SA and SST wall functions #1204

Fix SA and SST wall functions #1204

Conversation

bigfooted commented Feb 22, 2021 • edited Loading

Proposed Changes

Related Work

PR Checklist

TobiKattmann left a comment

Choose a reason for hiding this comment

pcarruscag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bigfooted commented Mar 2, 2021

pcarruscag commented Mar 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pcarruscag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bigfooted commented Jun 22, 2021

bigfooted commented Feb 22, 2021 •

edited

Loading