feat(TextFormatter): Support vertical alignment, overflow, line height #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the XTextFormatter class to...
Additionally, this seemed like a good opportunity to introduce some sort of unit testing and settled on visual facts. I created these on OSX and suspect they may not match across all platforms due to font anti-aliasing. Putting this out for initial feedback and will do some further testing when I have chance.
This introduces a dependency in Magick.NET within the .Test project to perform the visual diff. If differences are found, the test helper will output a _diff.png file to aid in assessing the change.