Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add royalty module's methods and strictly validation #140

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

bonnie57
Copy link
Collaborator

Description

  1. Add royalty methods including getRoyaltyVaultProxyAddress, snapshot, claimableRevenue
  2. Add strictly validations
  3. Add royalty integration tests

Test Result

image image

Notes

  1. Due to time constraints, we are foregoin unit tests. To ensure the successful execution of the pipeline, I am disabling coverage.
  2. As a result of using MockERC721, I am skipping all integration tests to ensure the pipeline runs smoothly. Local results have already been demonstrated in the test panel.
  3. Given the dynamic nature of royaltyValueAddress, passing the address is necessary when calling royalty-related methods. Following Lutty's suggestion, I will create a new instance to accommodate dynamic addresses.

@edisonz0718 edisonz0718 merged commit dbafc4f into storyprotocol:dev Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants