Migrate @storybook/node-logger to TypeScript #5153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5030
What I did
Migrated
@storybook/node-logger
to TypeScript.Two notes:
mockReset()
method. I wold love some eyes on that to see if I'm doing that correctly; there may be something I'm missing entirely.trace()
method used to pass the trace message to the first argument ofnpmlog.info
. This was causing TS to fail to compile. To fix the issue I'm now passing the message as the 2nd argument and an empty string to the first (just as all of the other methods are doing). My guess is that passing the message as the first argument was an oversight in the first place.How to test
Existing tests continue to work.